separate types for BlockPosition thats chunk relative #113
Labels
No labels
complexity
high
complexity
low
complexity
medium
importance
high
importance
low
importance
medium
type
bug
type
chore
type
feature suggestion
type
missing feature
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
thetxt/oxide#113
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
At the moment its possible to call a function that expects an input BlockPosition to be relative to the chunk with a BlockPosition containing a global position. This could be a source of bugs, if someone isnt careful.
Utilize the typesystem to distinguish between the two representations, implement functions to convert between the two
Also implement a type for the abomination returned by position.convert_to_coordinates_of_chunk
maybe also a type for blockpositions in a chunksection, this could have an impl to get the numeric id used in the chunk sections block arrays