thetxt/oxide
2
7
Fork 5
Code Issues 25 Pull requests 1 Projects Releases 13 Packages 1 Wiki Activity Actions

adding plugin messages #83 #85

Merged
thetxt merged 5 commits from JRBlockkop/oxide-xyz:plugin-messages into 0.8.0 2026-05-20 18:17:52 +02:00
Conversation 5 Commits 5 Files changed 3 +102
JRBlockkop commented 2026-05-20 17:41:31 +02:00
Contributor
Copy link
No description provided.
thetxt self-assigned this 2026-05-20 17:44:44 +02:00
thetxt added this to the 0.8.0 milestone 2026-05-20 17:44:47 +02:00
thetxt commented 2026-05-20 17:54:18 +02:00
Owner
Copy link

please make clippy happy:

warning: unnecessary use of `to_string`
   --> server/src/packet_handlers.rs:181:38
    |
181 |         data: lib::serialize::string(&"Oxide".to_string())
    |                                      ^^^^^^^^^^^^^^^^^^^^ help: use: `"Oxide"`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
    = note: `#[warn(clippy::unnecessary_to_owned)]` on by default

warning: `server` (bin "server") generated 1 warning (run `cargo clippy --fix --bin "server" -p server -- ` to apply 1 suggestion)
    Finished `dev` profile [optimized + debuginfo] target(s) in 0.04s

And also please run cargo fmt:

lukas@LukasBook server % cargo fmt --check
Diff in /Users/lukas/src/oxide/server/src/packet_handlers.rs:178:
 			lib::packets::clientbound::configuration::ClientboundPluginMessage::PACKET_ID,
 			lib::packets::clientbound::configuration::ClientboundPluginMessage {
 				channel: "minecraft:brand".to_string(),
-        data: lib::serialize::string(&"Oxide".to_string())
+				data: lib::serialize::string(&"Oxide".to_string()),
 			}
 			.try_into()?,
 		);

Looks good otherwise

please make clippy happy: ``` warning: unnecessary use of `to_string` --> server/src/packet_handlers.rs:181:38 | 181 | data: lib::serialize::string(&"Oxide".to_string()) | ^^^^^^^^^^^^^^^^^^^^ help: use: `"Oxide"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned = note: `#[warn(clippy::unnecessary_to_owned)]` on by default warning: `server` (bin "server") generated 1 warning (run `cargo clippy --fix --bin "server" -p server -- ` to apply 1 suggestion) Finished `dev` profile [optimized + debuginfo] target(s) in 0.04s ``` And also please run cargo fmt: ``` lukas@LukasBook server % cargo fmt --check Diff in /Users/lukas/src/oxide/server/src/packet_handlers.rs:178: lib::packets::clientbound::configuration::ClientboundPluginMessage::PACKET_ID, lib::packets::clientbound::configuration::ClientboundPluginMessage { channel: "minecraft:brand".to_string(), - data: lib::serialize::string(&"Oxide".to_string()) + data: lib::serialize::string(&"Oxide".to_string()), } .try_into()?, ); ``` Looks good otherwise
JRBlockkop changed title from adding plugin messages #84 to adding plugin messages #83 2026-05-20 18:11:44 +02:00
JRBlockkop commented 2026-05-20 18:17:27 +02:00
Author
Contributor
Copy link

I think I fix it

> cargo clippy && cargo fmt --check
    Finished `dev` profile [optimized + debuginfo] target(s) in 0.12s

now I know what clippy is

I think I fix it ``` > cargo clippy && cargo fmt --check Finished `dev` profile [optimized + debuginfo] target(s) in 0.12s ``` now I know what clippy is
thetxt merged commit c02baaa91f into 0.8.0 2026-05-20 18:17:52 +02:00
thetxt referenced this pull request from a commit 2026-05-20 18:21:52 +02:00
fix for #85
thetxt commented 2026-05-20 18:23:18 +02:00
Owner
Copy link

I think I still need to figure out how can I manually approve forgejo actions to run for PRs that arent from me 🤔
And maybe I should write some short kind of contribution guide

I think I still need to figure out how can I manually approve forgejo actions to run for PRs that arent from me 🤔 And maybe I should write some short kind of contribution guide
thetxt requested review from thetxt 2026-05-20 18:23:26 +02:00
JRBlockkop commented 2026-05-20 18:27:04 +02:00
Author
Contributor
Copy link

how did you check for the tab and spaces my ide hates me i have it set up for this repo to use Tab Size: 2

how did you check for the tab and spaces my ide hates me i have it set up for this repo to use Tab Size: 2
thetxt commented 2026-05-20 18:31:03 +02:00
Owner
Copy link

With cargo fmt --check. I also setup my IDE to automatically format on save. This all uses the rustfmt.toml with the project specific settings

With `cargo fmt --check`. I also setup my IDE to automatically format on save. This all uses the rustfmt.toml with the project specific settings
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
complexity
high

  
complexity
low

  
complexity
medium

  
importance
high

  
importance
low

  
importance
medium

  
type
bug
something that should work, but doesn't

  
type
chore
something that should be done at some point, but doesn't really change functionality

  
type
feature suggestion
a feature that should probably be implemented

  
type
missing feature
feature that should really be working by now, but doesn't

No labels
complexity
high
complexity
low
complexity
medium
importance
high
importance
low
importance
medium
type
bug
type
chore
type
feature suggestion
type
missing feature
Milestone
Clear milestone
No items
No milestone
0.8.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
thetxt
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
thetxt/oxide!85
No description provided.