thetxt/oxide
2
7
Fork 5
Code Issues 25 Pull requests 1 Projects Releases 13 Packages 1 Wiki Activity Actions

Added permission system #106

Open
Fix448 wants to merge 2 commits from Fix448/oxide:permission into dev
pull from: Fix448/oxide:permission
merge into: thetxt:dev
Conversation 5 Commits 2 Files changed 19 +162 -3
Fix448 commented 2026-06-01 17:30:55 +02:00
First-time contributor
Copy link

Added permission system with /op and /deop command

Added permission system with /op and /deop command
added permission system
All checks were successful
Build, test and push / formatting (pull_request_target) Successful in 9s
Details
Build, test and push / clippy (pull_request_target) Successful in 56s
Details
Build, test and push / test (pull_request_target) Successful in 2m23s
Details
9b30cf433e
thetxt self-assigned this 2026-06-01 18:11:05 +02:00
thetxt added this to the 0.9.0 milestone 2026-06-01 18:11:10 +02:00
thetxt reviewed 2026-06-01 18:13:40 +02:00
lib/src/types/player.rs Outdated
@ -138,6 +139,7 @@ impl Clone for Player {
dimension: self.dimension.clone(),
loaded_chunks: self.loaded_chunks.clone(),
portal_cooldown: self.portal_cooldown,
permission: Permission::Everyone,
thetxt commented 2026-06-01 18:13:40 +02:00
Owner
Copy link

this should be self.permission

this should be self.permission
thetxt commented 2026-06-01 18:16:48 +02:00
Owner
Copy link

thanks for contributing! Please talk to me first in the future, to ensure that I can merge your changes.
From my quick look I only found one minor thing that should be fixed (attached a comment in the review).
Other than that I think this is missing saving/loading permissions to/from disk. Ideally using the vanilla ops file format

thanks for contributing! Please talk to me first in the future, to ensure that I can merge your changes. From my quick look I only found one minor thing that should be fixed (attached a comment in the review). Other than that I think this is missing saving/loading permissions to/from disk. Ideally using the vanilla ops file format
Fix448 changed title from Added permission system to WIP: Added permission system 2026-06-01 20:08:15 +02:00
Fix448 changed title from WIP: Added permission system to Added permission system 2026-06-01 20:08:46 +02:00
Fix448 commented 2026-06-01 20:17:01 +02:00
Author
First-time contributor
Copy link

Would it be OK to use serde and serde_json for the ops.json file?

Would it be OK to use serde and serde_json for the ops.json file?
changed Permission::Everyone in clone()
All checks were successful
Build, test and push / formatting (pull_request_target) Successful in 9s
Details
Build, test and push / clippy (pull_request_target) Successful in 59s
Details
Build, test and push / test (pull_request_target) Successful in 2m21s
Details
96d2701a95
thetxt commented 2026-06-03 16:58:22 +02:00
Owner
Copy link

@Fix448 wrote in #106 (comment):

Would it be OK to use serde and serde_json for the ops.json file?

I would prefer to not add additional dependencies if we can avoid it

@Fix448 wrote in https://git.thetxt.io/thetxt/oxide/pulls/106#issuecomment-780: > Would it be OK to use serde and serde_json for the ops.json file? I would prefer to not add additional dependencies if we can avoid it
Fix448 commented 2026-06-05 21:12:09 +02:00
Author
First-time contributor
Copy link

I don't think we can avoid it in the long run.

I don't think we can avoid it in the long run.
All checks were successful
Build, test and push / formatting (pull_request_target) Successful in 9s
Details
Build, test and push / clippy (pull_request_target) Successful in 59s
Details
Build, test and push / test (pull_request_target) Successful in 2m21s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u permission:Fix448-permission
git switch Fix448-permission

Merge

Merge the changes and update on Forgejo.
git switch dev
git merge --no-ff Fix448-permission
git switch Fix448-permission
git rebase dev
git switch dev
git merge --ff-only Fix448-permission
git switch Fix448-permission
git rebase dev
git switch dev
git merge --no-ff Fix448-permission
git switch dev
git merge --squash Fix448-permission
git switch dev
git merge --ff-only Fix448-permission
git switch dev
git merge Fix448-permission
git push origin dev
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
complexity
high

  
complexity
low

  
complexity
medium

  
importance
high

  
importance
low

  
importance
medium

  
type
bug
something that should work, but doesn't

  
type
chore
something that should be done at some point, but doesn't really change functionality

  
type
feature suggestion
a feature that should probably be implemented

  
type
missing feature
feature that should really be working by now, but doesn't

No labels
complexity
high
complexity
low
complexity
medium
importance
high
importance
low
importance
medium
type
bug
type
chore
type
feature suggestion
type
missing feature
Milestone
Clear milestone
No items
No milestone
0.9.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
thetxt
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
thetxt/oxide!106
No description provided.